/nick fail

[lordmaker1234]

Im trying to make a /nick command where you can only nick people witha lower rank, but I cant get it to work. Can someone find what is wrong with it Please. (This is my 1st command and I kinda suck at this sort of stuff)

Code: Select all

using System;
using MCDzienny_;

namespace MCDzienny
{
    public class Cmdnick : Command
    {
        public override string name { get { return "nicktest"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "other"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Admin; } }

        public override void Use(Player p, string message)
        {
            if (message[0] == '#')
            {
                message = message.Remove(0, 1);
                foreach (Player current in Player.players)
                {
                    current.PublicName = message;
                }

                return;
            }

            if (message == "undo")
            {
                foreach (Player current in Player.players)
                {
               string name = current.name;
               if (name.Contains("@"))
               {
                  name = name.Remove(name.IndexOf('@') + 1);
               }
               
                    current.PublicName = name;
                }
           
            return;
            }

            Player who = Player.Find(message.Split(' ')[0]);
            if (who != null)
            {
                who.PublicName = message.Split(' ')[1];
           {
         Player.SendMessage(p, "Player not found.");
            }
        }

          }
            else
            {
         }
         if (who.group.Permission > p.group.Permission)
         {
            Player.SendMessage(p, "You cannot use this command someone ranked higher than you.");
            return;
               
        public override void Help(Player p)
        {
            Player.SendMessage(p, "/nick <player> [name] - Changes <name> name");
        }
    }


[HETAL]

Your namespace is suppose to be MCDzienny not mcdzienny_

[lordmaker1234]

Your namespace is suppose to be MCDzienny not mcdzienny_

Oh ye i knew about that just after i posted it, but error is:

Code: Select all

-------------------------

Error #CS1519
Message: Invalid token 'else' in class, struct, or interface member declaration
Line: 53

-------------------------

Error #CS1519
Message: Invalid token '>' in class, struct, or interface member declaration
Line: 56

-------------------------

Error #CS1519
Message: Invalid token ')' in class, struct, or interface member declaration
Line: 56

-------------------------

Error #CS1519
Message: Invalid token '(' in class, struct, or interface member declaration
Line: 58

-------------------------

Error #CS1519
Message: Invalid token ',' in class, struct, or interface member declaration
Line: 58


I Am A Noob's Noob At This Sort Of Stuff, So I Dont Know What Any Of That Means

[joppiesaus]

I think you messed up your brackets.

[Leeizazombie]

There was a good few errors in the code. Here's an error free one I hope, I didn't compile it to test so let me know!

Code: Select all

using System;
using MCDzienny;

namespace MCDzienny
{
    public class Cmdnick : Command
    {
        public override string name { get { return "nicktest"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "other"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Admin; } }
        public override void Use(Player p, string message)
        {
            if (message[0] == '#')
            {
                message = message.Remove(0, 1);
                foreach (Player current in Player.players)
                {
                    current.PublicName = message;
                }

                return;
            }

            if (message == "undo")
            {
                foreach (Player current in Player.players)
                {
                    string name = current.name;
                    if (name.Contains("@"))
                    {
                        name = name.Remove(name.IndexOf('@') + 1);
                    }

                    current.PublicName = name;
                }

                return;
            }

            Player who = Player.Find(message.Split(' ')[0]);
            if (who != null)
            {
                who.PublicName = message.Split(' ')[1];
                {
                    if (who.group.Permission > p.group.Permission)
                    {
                        Player.SendMessage(p, "You cannot use this command someone ranked higher than you.");
                        return;
                    }

                    Player.SendMessage(p, "Player not found.");
                }
            }
        }

        public override void Help(Player p)
        {
            Player.SendMessage(p, "/nick <player> [name] - Changes <name> name");
        }
    }
}


[joppiesaus]

Ok, I see some errors now...
message[0] is undifined, change it to
if (message.Substring(1))

the second, did you meant this(?):
if (message.Split(' ')[0] == "undo")

Remember that message.Split(' ')[1] is unsafe code, it can cause a IndexOutOfRange exception if you don't provide any spaces.

The brackets after who.PublicName = message.Split(' ')[1]; are useless, remove them.

But the rest is good I think!

[ismellike]

message[0] is undifined, change it to
if (message.Substring(1))

message.Substring(1) returns everything that is after position e.g. hello -> llo

message[0] is valid; maybe you should check to make sure that message != "".

if (message.Split(' ')[0] == "undo")

could be used but is not needed since he is not splitting elsewhere after that clause.

Other than that, try what joppie said if you get errors.

[lordmaker1234]

Thanks Guys, I Think I Get It Now

[joppiesaus]

message[0] is undifined, change it to
if (message.Substring(1))

message.Substring(1) returns everything that is after position e.g. hello -> llo

message[0] is valid; maybe you should check to make sure that message != "".

if (message.Split(' ')[0] == "undo")

could be used but is not needed since he is not splitting elsewhere after that clause.

Other than that, try what joppie said if you get errors.

Yeah... I mixed up the Substring part!

And it's not about the

if (message.Split(' ')[0] == "undo")

but the

who.PublicName = message.Split(' ')[1];

Good luck lordmaker1234!