/piss

[Breakdown901]

Yeah, quite a creepy name Anyways, I'm getting errors.

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
         if (message == "") { Help(p); return; }

                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }

                else
            {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, " water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, " waterfall");
            }
         }

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

It compiles and loads, when you do /piss [player], it works. But /piss myself and /piss frenzy both come up player not found. Also, /piss [player] shows an error saying invalid parameters, but still works.

[joppiesaus]

The else block is not connected to the if block. I think it would fix the problems.
You have:

Code: Select all

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }

                else
            {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }

it should be:

Code: Select all

       
             if (who == null)
             {
                 Player.SendMessage(p, "Player not found!");
                 return;
             }
             else
             {
                Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
                Command.all.Find("place").Use(who, " water");
             }

EDIT: I thought you had compiler errors -_-
The problem is you defined a player with the message and you can't reach the other if blocks(hard to explain)
Here's the fix.

Code: Select all

       
            if (message != myself && message != frenzy)
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
                   Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
                   Command.all.Find("place").Use(who, " water");
                }
            }

[Clowny]

Hahaha omg I love the use of water command

[Breakdown901]

Joppie, after I added your bit I got compiler errors.

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
                
            if (message != myself && message != frenzy)
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, " water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, " waterfall");
            }
      }   }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

Errors:

Code: Select all

-------------------------

Error #CS0103
Message: The name 'myself' does not exist in the current context
Line: 15

-------------------------

Error #CS0103
Message: The name 'frenzy' does not exist in the current context
Line: 15


[joppiesaus]

Joppie, after I added your bit I got compiler errors.

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
                
            if (message != myself && message != frenzy)
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, " water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, " waterfall");
            }
      }   }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

Errors:

Code: Select all

-------------------------

Error #CS0103
Message: The name 'myself' does not exist in the current context
Line: 15

-------------------------

Error #CS0103
Message: The name 'frenzy' does not exist in the current context
Line: 15


*headdesk*
I forgot the "".
Replace this:

Code: Select all

            if (message != myself && message != frenzy)

With this:

Code: Select all

            if (message != "myself" && message != "frenzy")

I don't know why I didn't put the string characters.

[Breakdown901]

xD

We all make mistakes, like me trying to learn to code MCDzienny commands when I'm hopeless xD

[Breakdown901]

I'm having the same problem as I had before. It compiles, and loads,. When I use /piss [player], it does it but underneath it, it says "Invalid parameters". When I do /piss myself, it does absolutely nothing, same with /piss frenzy.

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
                
            if (message != "myself" && message != "frenzy")
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, " water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, " waterfall");
            }
      }   }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

[joppiesaus]

I'm having the same problem as I had before. It compiles, and loads,. When I use /piss [player], it does it but underneath it, it says "Invalid parameters". When I do /piss myself, it does absolutely nothing, same with /piss frenzy.

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
                
            if (message != "myself" && message != "frenzy")
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, " water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, " waterfall");
            }
      }   }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

That's really, really weird. I don't understand that problem. Maybe remove the spaces by p.use?
And here some coding style corrections:

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
               
            if (message != "myself" && message != "frenzy")
            {
                Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
               }
            }
            if (message == "myself")
            {
               Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, "water");
            }
            if (message == "frenzy")
            {
               Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, "waterfall");
            }
      }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}

EDIT: fixed!
you place the "}" wrong!
Try to make it look like eyecandy. It will compile much better!

[Breakdown901]

Havent had the chance to test it yet, but thanks for everything!

[qpqpqp123]

in that more nice work with switch and case exam of that on cmd like your:

Code: Select all

//Made by Breakdown901
using System;
namespace MCDzienny
{
   public class CmdPiss : Command
   {
      public override string name { get { return "piss"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }
      public override void Use(Player p, string message)
      {
            switch (message)
            {
                case "myself":
                    Player.GlobalMessage(p.PublicName + " just pissed on their self!");
               Command.all.Find("place").Use(p, "water");
                    break;
                case "frenzy":
                    Player.GlobalMessage(p.PublicName + " really had to go! &cRUN!!!");
               Command.all.Find("physics").Use(p, "3");
               Command.all.Find("place").Use(p, "waterfall");
                    break;
                default:
                  Player who = Player.Find(message);

                if (who == null)
                {
                    Player.SendMessage(p, "Player not found!");
                    return;
                }
                else
                {
               Player.GlobalMessage(p.color + p.PublicName + " just pissed on " + who.PublicName);
               Command.all.Find("place").Use(who, " water");
               }
                    break;
            }
      }
         

      public override void Help(Player p)
      {
         Player.SendMessage(p, "/piss - /piss [player] - Piss on someone.");
         Player.SendMessage(p, "/piss myself - Piss on yourselve.");
         Player.SendMessage(p, "/piss frenzy - Use this if you really had to let it out!");
      }
   }
}