I don't know what is the error

[qpqpqp123]

could you help me

Code: Select all

using System;
using System.Data.SqlClient;
namespace MCDzienny
{
    public class CmdIgnore : Command
    {
        public override string name { get { return "contest";} }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "other"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Guest; } }
        public override bool ConsoleAccess { get { return false; } }
        public override void Use(Player p, string message)
        {
            if (p == null)
            {
                Player.SendMessage(p, "Cannot use this command.");
                return;
            }
            string[] a = message.Split(' ');

            string sqlUserName, sqlUserName2;
            SqlConnection con = new SqlConnection();[color=#BF0000]//I delete that It work I know that!!!! it isnt the problem[/color]
            con.Open();
            switch (a[0])
            {
                case "reset":
                    con.Open();
            SqlCommand cmd2 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd2.Parameters.AddWithValue("@Id", a[1]);
               
                int rows = cmd2.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, " contest have reset");
                    break;
                case "join":
                    con.Open();
                   
                     sqlUserName = "SELECT * FROM table2 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd11 =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader2 = cmd11.ExecuteReader();

                    if (!reader2.HasRows)
                    {
                        break;
                    }
                   
                    con.Close();
                   
                    con.Open();
                       SqlCommand cmd17 =new SqlCommand("INSERT INTO table1 VALUES(" + "@Id, @Name)", con);
                cmd17.Parameters.AddWithValue("@Id", a[1]);
                cmd17.Parameters.AddWithValue("@Name", a[2]);

               
                int rows17 = cmd17.ExecuteNonQuery();
               
                con.Close();
                    con.Close();
                    Player.SendMessage(p, "you join contest");
                    break;
                case "leave":
                     con.Open();
            SqlCommand cmd4 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id AND player="+p.name, con);

                cmd4.Parameters.AddWithValue("@Id", a[1]);
               
                int rows5 = cmd4.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "you leave contest");
                    break;
                case "start":
                    con.Open();
                    SqlCommand cmd7 =new SqlCommand("INSERT INTO table2 VALUES(" + "@Id)", con);
                cmd7.Parameters.AddWithValue("@Id", a[1]);
               

               
                int rows7 = cmd7.ExecuteNonQuery();
                Player.SendMessage(p, "contest have start");
                con.Close();
                    break;
                case "point":
                    con.Open();
                    SqlCommand cmd8 = new SqlCommand("UPDATE table1 SET point=@point WHERE Id=@Id AND contest=@Address", con);
           
                cmd8.Parameters.AddWithValue("@Id",Convert.ToInt16(a[3]));
                cmd8.Parameters.AddWithValue("@point", a[2]);
                cmd8.Parameters.AddWithValue("@Address", a[1]);

                int rows12 = cmd8.ExecuteNonQuery();

                con.Close();
                Player.SendMessage(p, "point have set to player");
                    break;
                case "view":
                    con.Open();
                    sqlUserName = "SELECT * FROM table1 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader = cmd.ExecuteReader();
                    Player.SendMessage(p, "players are on " +a[1] +" contest");
                if (reader.HasRows)
                {
                    while (reader.Read())
                    {
                        Player.SendMessage(p, ""+reader["player"]);
                       
                    }
                }
                con.Close();
                    break;
                case "end":

            con.Open();
            SqlCommand cmd3 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd3.Parameters.AddWithValue("@Id", a[1]);
               
                int rows2 = cmd3.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                     con.Open();
            SqlCommand cmd6 = new SqlCommand("DELETE FROM table2 " + "WHERE contest=@Id", con);

                cmd6.Parameters.AddWithValue("@Id", a[1]);
               
                int rows6 = cmd6.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "contest end");
                    break;

            }
           
           

           
        }
        public override void Help(Player p)
        {
            Player.SendMessage(p, "~");
        }
    }
}


[HETAL]

the public class should be CmdContest instead of CmdIgnore

[qpqpqp123]

but isn't solve the probelm
errors

Code: Select all


----25-07-2013 Thursday 16:25:49 ----
Type: InvalidOperationException
Source: System.Data
Message: The connection was not closed. The connection's current state is open.
Target: OpenConnection
Trace:    at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.SqlClient.SqlConnection.Open()
   at MCDzienny.CmdIgnore.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()

-------------------------

----25-07-2013 Thursday 17:53:56 ----
Type: InvalidOperationException
Source: System.Data
Message: The connection was not closed. The connection's current state is open.
Target: OpenConnection
Trace:    at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.SqlClient.SqlConnection.Open()
   at MCDzienny.CmdContest.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()

-------------------------

----25-07-2013 Thursday 17:56:09 ----
Type: InvalidOperationException
Source: System.Data
Message: The connection was not closed. The connection's current state is open.
Target: OpenConnection
Trace:    at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.SqlClient.SqlConnection.Open()
   at MCDzienny.CmdContest.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()

-------------------------

----25-07-2013 Thursday 17:56:25 ----
Type: InvalidOperationException
Source: System.Data
Message: The connection was not closed. The connection's current state is open.
Target: OpenConnection
Trace:    at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.SqlClient.SqlConnection.Open()
   at MCDzienny.CmdContest.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()



[Breakdown901]

Looks like an SQL error to me, I'd check the part of your SQL code.

[qpqpqp123]

I dont know what is problem

[Clowny]

Well this is a bit confusing not getting what you're trying to do how ever the error is telling you that for example something like this:

Code: Select all

con.Open();
            SqlCommand cmd2 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

Is being kept open and not closed afterwards..
I can't revise it an do it for you since I'm not an expert but look for that

[Breakdown901]

Try this

Code: Select all

using System;
using System.Data.SqlClient;
namespace MCDzienny
{
    public class CmdIgnore : Command
    {
        public override string name { get { return "contest";} }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "other"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Guest; } }
        public override bool ConsoleAccess { get { return false; } }
        public override void Use(Player p, string message)
        {
            if (p == null)
            {
                Player.SendMessage(p, "Cannot use this command.");
                return;
            }
            string[] a = message.Split(' ');

            string sqlUserName, sqlUserName2;
            SqlConnection con = new SqlConnection();[color=#BF0000]//I delete that It work I know that!!!! it isnt the problem[/color]
            con.Open();
            switch (a[0])
            {
                case "reset":
                    con.Open();
            SqlCommand cmd2 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd2.Parameters.AddWithValue("@Id", a[1]);
               
                int rows = cmd2.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, " contest have reset");
                    break;
                case "join":
                    con.Open();
                   
                     sqlUserName = "SELECT * FROM table2 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd11 =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader2 = cmd11.ExecuteReader();

                    if (!reader2.HasRows)
                    }
                    {
                        break;
                    }
                   
                    con.Close();
                   
                    con.Open();
                       SqlCommand cmd17 =new SqlCommand("INSERT INTO table1 VALUES(" + "@Id, @Name)", con);
                cmd17.Parameters.AddWithValue("@Id", a[1]);
                cmd17.Parameters.AddWithValue("@Name", a[2]);

               
                int rows17 = cmd17.ExecuteNonQuery();
               
                con.Close();
                    con.Close();
                    Player.SendMessage(p, "you join contest");
                    break;
                case "leave":
                     con.Open();
            SqlCommand cmd4 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id AND player="+p.name, con);

                cmd4.Parameters.AddWithValue("@Id", a[1]);
               
                int rows5 = cmd4.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "you leave contest");
                    break;
                case "start":
                    con.Open();
                    SqlCommand cmd7 =new SqlCommand("INSERT INTO table2 VALUES(" + "@Id)", con);
                cmd7.Parameters.AddWithValue("@Id", a[1]);
               

               
                int rows7 = cmd7.ExecuteNonQuery();
                Player.SendMessage(p, "contest have start");
                con.Close();
                    break;
                case "point":
                    con.Open();
                    SqlCommand cmd8 = new SqlCommand("UPDATE table1 SET point=@point WHERE Id=@Id AND contest=@Address", con);
           
                cmd8.Parameters.AddWithValue("@Id",Convert.ToInt16(a[3]));
                cmd8.Parameters.AddWithValue("@point", a[2]);
                cmd8.Parameters.AddWithValue("@Address", a[1]);

                int rows12 = cmd8.ExecuteNonQuery();

                con.Close();
                Player.SendMessage(p, "point have set to player");
                    break;
                case "view":
                    con.Open();
                    sqlUserName = "SELECT * FROM table1 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader = cmd.ExecuteReader();
                    Player.SendMessage(p, "players are on " +a[1] +" contest");
                if (reader.HasRows)
                {
                    while (reader.Read())
                    {
                        Player.SendMessage(p, ""+reader["player"]);
                       
                    }
                }
                con.Close();
                    break;
                case "end":

            con.Open();
            SqlCommand cmd3 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd3.Parameters.AddWithValue("@Id", a[1]);
               
                int rows2 = cmd3.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                     con.Open();
            SqlCommand cmd6 = new SqlCommand("DELETE FROM table2 " + "WHERE contest=@Id", con);

                cmd6.Parameters.AddWithValue("@Id", a[1]);
               
                int rows6 = cmd6.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "contest end");
                    break;

            }
           
           

           
        }
        public override void Help(Player p)
        {
            Player.SendMessage(p, "~");
        }
    }
}

[Breakdown901]

Ok that doesnt work, but fixed part of it. Try and work it out from these errors.

Code: Select all

-------------------------

Error #CS1040
Message: Preprocessor directives must appear as the first non-whitespace character on a line
Line: 23

-------------------------

Error #CS1518
Message: Expected class, delegate, enum, interface, or struct
Line: 149

-------------------------

Error #CS1022
Message: Type or namespace definition, or end-of-file expected
Line: 154


[qpqpqp123]

error after I fix your code and that the error

Code: Select all

----25-07-2013 Thursday 22:26:23 ----
Type: SqlException
Source: .Net SqlClient Data Provider
Message: Column name or number of supplied values does not match table definition.
Target: OnError
Trace:    at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection)
   at System.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj)
   at System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj)
   at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)
   at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async)
   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, DbAsyncResult result)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(DbAsyncResult result, String methodName, Boolean sendToPipe)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at MCDzienny.CmdContest.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()

-------------------------



[qpqpqp123]

I change it and have error after
like you say and that the code

Code: Select all


using System;
using System.Data.SqlClient;
namespace MCDzienny
{
    public class Cmdcontest : Command
    {
        public override string name { get { return "contest";} }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "other"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Guest; } }
        public override bool ConsoleAccess { get { return false; } }
        public override void Use(Player p, string message)
        {
            if (p == null)
            {
                Player.SendMessage(p, "Cannot use this command.");
                return;
            }
            string[] a = message.Split(' ');

            string sqlUserName, sqlUserName2;
            SqlConnection con = new SqlConnection(delete);
            con.Open();
            switch (a[0])
            {
                case "reset":
                    con.Open();
            SqlCommand cmd2 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd2.Parameters.AddWithValue("@Id", a[1]);
               
                int rows = cmd2.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, " contest have reset");
                    break;
                case "join":
                    con.Open();
                   
                     sqlUserName = "SELECT * FROM table2 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd11 =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader2 = cmd11.ExecuteReader();

                    if (!reader2.HasRows)
                   
                    {
                        break;
                    }
                   
                    con.Close();
                   
                    con.Open();
                       SqlCommand cmd17 =new SqlCommand("INSERT INTO table1 VALUES(" + "@Id, @Name)", con);
                cmd17.Parameters.AddWithValue("@Id", a[1]);
                cmd17.Parameters.AddWithValue("@Name", a[2]);

               
                int rows17 = cmd17.ExecuteNonQuery();
               
                con.Close();
                    con.Close();
                    Player.SendMessage(p, "you join contest");
                    break;
                case "leave":
                     con.Open();
            SqlCommand cmd4 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id AND player="+p.name, con);

                cmd4.Parameters.AddWithValue("@Id", a[1]);
               
                int rows5 = cmd4.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "you leave contest");
                    break;
                case "start":
                    con.Open();
                    SqlCommand cmd7 =new SqlCommand("INSERT INTO table2 VALUES(" + "@Id)", con);
                cmd7.Parameters.AddWithValue("@Id", a[1]);
               

               
                int rows7 = cmd7.ExecuteNonQuery();
                Player.SendMessage(p, "contest have start");
                con.Close();
                    break;
                case "point":
                    con.Open();
                    SqlCommand cmd8 = new SqlCommand("UPDATE table1 SET point=@point WHERE Id=@Id AND contest=@Address", con);
           
                cmd8.Parameters.AddWithValue("@Id",Convert.ToInt16(a[3]));
                cmd8.Parameters.AddWithValue("@point", a[2]);
                cmd8.Parameters.AddWithValue("@Address", a[1]);

                int rows12 = cmd8.ExecuteNonQuery();

                con.Close();
                Player.SendMessage(p, "point have set to player");
                    break;
                case "view":
                    con.Open();
                    sqlUserName = "SELECT * FROM table1 WHERE contest ='" + a[1] + "'";
                    SqlCommand cmd =
                new SqlCommand(sqlUserName, con);
                    SqlDataReader reader = cmd.ExecuteReader();
                    Player.SendMessage(p, "players are on " +a[1] +" contest");
                if (reader.HasRows)
                {
                    while (reader.Read())
                    {
                        Player.SendMessage(p, ""+reader["player"]);
                       
                    }
                }
                con.Close();
                    break;
                case "end":

            con.Open();
            SqlCommand cmd3 = new SqlCommand("DELETE FROM table1 " + "WHERE contest=@Id", con);

                cmd3.Parameters.AddWithValue("@Id", a[1]);
               
                int rows2 = cmd3.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                     con.Open();
            SqlCommand cmd6 = new SqlCommand("DELETE FROM table2 " + "WHERE contest=@Id", con);

                cmd6.Parameters.AddWithValue("@Id", a[1]);
               
                int rows6 = cmd6.ExecuteNonQuery();

                //rows number of record got deleted
                con.Close();
                Player.SendMessage(p, "contest end");
                    break;

            }
           
           

           
        }
        public override void Help(Player p)
        {
            Player.SendMessage(p, "~");
        }
    }
}

that the error

Code: Select all

----25-07-2013 Thursday 22:33:41 ----
Type: InvalidOperationException
Source: System.Data
Message: The connection was not closed. The connection's current state is open.
Target: OpenConnection
Trace:    at System.Data.ProviderBase.DbConnectionInternal.OpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory)
   at System.Data.SqlClient.SqlConnection.Open()
   at MCDzienny.Cmdcontest.Use(Player p, String message)
   at MCDzienny.Player.<>c__DisplayClass26.<HandleCommand>b__21()

-------------------------