/pay (rewritting to follow who.hidden)

[Warren1001]

Errors:

Spoiler:

Code: Select all

-------------------------

Error CS0165
Message: Use of unassigned local variable 'amountPaid'
Line: 48

Command:

Spoiler:

Code: Select all

using System;

namespace MCDzienny
{
   public class CmdPay : Command
   {
      public override string name { get { return "pay"; } }
      public override string shortcut { get { return ""; } }
      public override string type { get { return "other"; } }
      public override bool museumUsable { get { return false; } }
      public override LevelPermission defaultRank { get { return LevelPermission.Guest; } }

      public override void Use(Player p, string message)
      {
         if (message.IndexOf(' ') == -1)
         {
            Help(p);
            return;
         }
            if (message.Split(' ').Length != 2)
         {
            Help(p);
            return;
         }
            else
         {
            Player who = Player.Find(message.Split(' ')[0]);
            if (who == null || who.hidden)
            {
               Player.SendMessage(p, "Player could not be found.");
            }
            else if (who == p)
            {
               Player.SendMessage(p, "You cannot pay yourself.");
            }
            else
            {
               int amountPaid;
               try
               {
                  amountPaid = int.Parse(message.Split(' ')[1]);
               }
               catch
               {
                  Player.SendMessage(p, "Invalid amount.");
               }
               
               if (who.money + amountPaid > 16777215)
               {
                  Player.SendMessage(p, "Players cannot have over 16777215 " + Server.moneys + ".");
               }
               else if (p.money - amountPaid < 0)
               {
                  Player.SendMessage(p, "You don't have that much " + Server.moneys + ".");
               }
               else if (amountPaid < 0)
               {
                  Player.SendMessage(p, "Cannot pay negative " + Server.moneys + ".");
               }
               who.money += amountPaid;
               p.money -= amountPaid;
               // Player.GlobalMessage(p.color + p.name + Server.DefaultColor + " paid " + who.color + who.name + Server.DefaultColor + " " + amountPaid + " " + Server.moneys + ".");
               Player.SendMessage(p, Server.DefaultColor + "You paid " + who.color + who.name + Server.DefaultColor + " " + amountPaid + " " + Server.moneys + ".");
               Player.SendMessage(who, p.color + p.name + Server.DefaultColor + " paid you " + amountPaid + " " + Server.moneys + ".");
            }
         }
      }
      public override void Help(Player p)
      {
         Player.SendMessage(p, "/pay - pays a player.");
      }
   }
}

[Conor]

Change:

Code: Select all

int amountPaid;

To:

Code: Select all

int amountPaid = 0;

Right now the compiler would be saying this: What happens if the amountPaid variable isn't assigned in the try statement? It is caught so there is no error and the code can continue to be read; however the amountPaid variable wouldn't have been assigned any value, and then you're trying to use it.

[Warren1001]

Change:

Code: Select all

int amountPaid;

To:

Code: Select all

int amountPaid = 0;

Right now the compiler would be saying this: What happens if the amountPaid variable isn't assigned in the try statement? It is caught so there is no error and the code can continue to be read; however the amountPaid variable wouldn't have been assigned any value, and then you're trying to use it.

ty