/hide (rewritting to include welcome/farewell messages)

[Warren1001]

If you do /cmdcreate hide it will put the coding of /hide into your source folder and you can edit the code from that

That doesn't help me, I already have the command made.
Just two little errors.

[dzienny]

It wasn't that far from working. I made some changes to the code to make it work as intended

Spoiler:

Code: Select all

using MCDzienny.MultiMessages;

namespace MCDzienny
{
    public class CmdHide : Command
    {
        public override string name { get { return "hide"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "mod"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Operator; } }
        public override bool ConsoleAccess { get { return false; } }

        public override void Init()
        {
            // Remove the core command named "hide".
            Command.all.Remove(Command.all.Find("hide"));
        }

        public override void Use(Player p, string message)
        {
            if (p.possess != string.Empty)
            {
                Player.SendMessage(p, "Stop your current possession first.");
                return;
            }

            p.hidden = !p.hidden;

            Misc.Message msg = new Misc.Message(message);
            string firstArgument = msg.ReadStringLower();
            if (firstArgument != null && firstArgument != "s")
            {
                Help(p);
                return;
            }

            if (firstArgument == "s")
            {
                if (p.hidden)
                {
                    Player.GlobalDie(p, true);
                    Player.SendMessage(p, "You're now secretly %finvisible%s.");
                }
                else
                {
                    Player.GlobalSpawn(p);
                    Player.SendMessage(p, "You're now secretly %fvisible%s.");
                }
            }
            else
            {
                if (p.hidden)
                {
                    Player.GlobalDie(p, true);
                    Player.GlobalMessageOps("To Ops -" + p.color + p.name + "-%s is now %finvisible%s.");

                    if (p.farewellMessage == string.Empty)
                        Player.GlobalMessage(string.Format(MessagesManager.GetString("GlobalMessagePlayerDisconnected")
                            , "%c- " + p.color + p.prefix + p.PublicName + Server.DefaultColor));
                    else
                        Player.GlobalMessage("%c- " + p.color + p.prefix + p.PublicName + "%s " + p.farewellMessage);

                    Player.SendMessage(p, "You're now %finvisible%s.");
                }
                else
                {
                    Player.GlobalSpawn(p);
                    Player.GlobalMessageOps("To Ops -" + p.color + p.name + "-%s is now %8visible%s.");

                    if (p.welcomeMessage == string.Empty)
                        Player.GlobalMessage(string.Format(MessagesManager.GetString("GlobalMessagePlayerJoined")
                            , "%a+ " + p.color + p.prefix + p.color + p.PublicName + Server.DefaultColor));
                    else
                        Player.GlobalMessage("&a+ " + p.color + p.prefix + p.PublicName + "%s " + p.welcomeMessage);

                    Player.SendMessage(p, "You're now %fvisible%s.");
                }
            }
        }

        public override void Help(Player p)
        {
            Player.SendMessage(p, "/hide <s> - makes yourself (in)visible to other players.");
        }
    }
}

Changelog:

Spoiler:

new: removes the core command "hide" on initialization,
change: p.name -> p.PublicName - to hide email domains,
change: use of Misc.Message class to parse the arguments - more readable,
change: Server.DefaultColor was mostly replaced with "%s" code - more readable,
fix: Player.GlobalSpawn(p);
fix: works if a player doesn't have a message set.

Anyway, I consider it a bug that the hide command doesn't take into consideration farewell and welcome messages. So, I will fix it in some of the next versions. But, the code still may be useful to others if they want to make their own changes to it.

And, I highly advise using Visual Studio C# Express Edition, which is free, for creating custom commands. It makes the process much easier.

[ismellike]

But to remove it with Init, doesn't the command have to be loaded first?

[Conor]

But to remove it with Init, doesn't the command have to be loaded first?

I'm presuming the 'Init' method for the custom commands will be called before they are added to the Command.all list.

Therefore, it is possible to remove a previous command of the same name from the list, before the new one is added.

I'm not sure if this is the case but because you can do it, I'm guessing this is how.

So it might look like:

Code: Select all

// Some method called when a custom command is loaded using /cmdload.
// The Command passed through the method is the command which will be added.
public void LoadNewCustomCommand(Command cmd)
{
     cmd.Init();
     Command.all.Add(cmd);
}


[ismellike]

nice didn't think about that, I would have a separate command for unloading every command I needed, and then to load them.

[Conor]

nice didn't think about that, I would have a separate command for unloading every command I needed, and then to load them.

That code isn't something to put in your command btw, it was my representation of what might go on in MCDzienny source when a custom command is added

So I don't think you need the seperate command to unload the old ones, if you put it in the Init() method then it will work fine