need help with cmd

[dryfly21]

im not sure where the error is and i know that this is for MCForge but im sure that this is kinda like MCDzienny and i get a error whenever i do compile sayhi and it wont compile :/ not sure what went wrong and i am very new to C# and i would like some help with this plz

Code: Select all

using System;

namespace MCForge
{
                     public class CmdSayhi : Command
                    {
                      //Made by dryfly21 my first cmd for MCForge.
                      public override string name { get { return "sayhi"; } }
      public override string shortcut { get { return "hi"; } }
      public override string type { get { return "mod"; } }
      public override bool museumUsable { get { return true; } }
LevelPermission.Admin
      public override LevelPremission defaultRank { get { return LevelPremission.Guest; } }
      public override void Use(Player p, string message)
      {
             Player.SendMessage(p, "I'm saying hi to all my fellow players!");
             Player who = player.Find(message);
             if (who == null) { Player.SendMessage(p, "Could not find player entered"; return; }
             if(who == p) { Player.sendMessage(p, "Sorry, you can't say hi to yourself"); return; }
             Player.GlobalMessage(p.color + p.name + Server.DefaultColor + " I am saying hi to you " + who.color + who.name);
      }
         public override void Help(Player p)
      {
          Player.SendMessage(p, "/sayhi [player] - says hi to your fellow players.");
      }
   }
}

[Ultima]

Change namespace to "MCDzienny".

[dryfly21]

um ok but i made for mcforge though but i suppose mcdzienny is fine as well i did some more editing to it :/

Code: Select all

using System;

namespace MCDzienny
{
    public class CmdSayhi : Command
    {
        //Made by dryfly21 my first cmd for MCDzienny.
        public override string name { get { return "sayhi"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "mod"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPremission defaultRank { get { return LevelPremission.Banned; } }
       
public override void Use(Player p, string message){

        p.sayhi = !p.sayhi;
            if(p.sayhi)
            {
               Player.SendMessage(p, "I'm saying hi to you my fellow player!");
               Player who = player.Find(message);
               if (who == null) { Player.SendMessage(p, "Could not find player entered"); return; }
               if(who == p) { Player.sendMessage(p, "Sorry, you can't say hi to yourself"); return; }

            }
}
        public override void Help(Player p)
        {
            Player.SendMessage(p, "/sayhi [player] - says hi to your fellow players.");
        }
    }
}

[Ultima]

U might wanna remove the "p.sayhi" since it doesnt exist.
Most error's came from missing a capitale letter.

U used player and it needed Player.

Try this:

Code: Select all

using System;

namespace MCDzienny
{
    public class CmdSayhi : Command
    {
        //Made by dryfly21 my first cmd for MCDzienny.
        public override string name { get { return "sayhi"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "mod"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }

        public override void Use(Player p, string message)
        {
                Player.SendMessage(p, "I'm saying hi to you my fellow player!");
                Player who = Player.Find(message);
                if (who == null) { Player.SendMessage(p, "Could not find player entered"); return; }
                if (who == p) { Player.SendMessage(p, "Sorry, you can't say hi to yourself"); return; }
        }
        public override void Help(Player p)
        {
            Player.SendMessage(p, "/sayhi [player] - says hi to your fellow players.");
        }
    }
}

[dryfly21]

OMG wow thanks a bunch now the cmd works thx now im goin to submit it

[dzienny]

There's a bug in the code, the receiver of the message doesn't know who the sender is. The sender name is not displayed.
Here's the code that includes the sender color and sender name in the message.

Code: Select all

// Made by dryfly21 my first cmd for MCDzienny.

using System;

namespace MCDzienny
{
    public class CmdSayhi : Command
    {       
        public override string name { get { return "sayhi"; } }
        public override string shortcut { get { return ""; } }
        public override string type { get { return "mod"; } }
        public override bool museumUsable { get { return false; } }
        public override LevelPermission defaultRank { get { return LevelPermission.Banned; } }

        public override void Use(Player p, string message)
        {
            if (p == null)
            {
                Player.SendMessage(p, "This command can not be used from the console.");
                return;
            }

            Player.SendMessage(p, p.color + p.name + Server.DefaultColor + "> I'm saying hi to you my fellow player!");
            Player who = Player.Find(message);

            if (who == null)
            {
                Player.SendMessage(p, "Could not find player entered.");
                return;
            }
            if (who == p)
            {
                Player.SendMessage(p, "Sorry, you can't say hi to yourself.");
                return;
            }
        }

        public override void Help(Player p)
        {
            Player.SendMessage(p, "/sayhi [player] - says hi to your fellow players.");
        }
    }
}

[dryfly21]

sweet thanks for fixing it bro